Add TON support #486
Add TON support #486
Conversation
🦋 Changeset detectedLatest commit: cfba89d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gustavogama-cll
left a comment
There was a problem hiding this comment.
I have a few requests, if you please.
- add a changeset file
- remove the .envrc file. We don't mind if you want to use nix, but we don't want to enforce it by default
- consider adding unit tests; I understand it's just an initial PR, but we do try have good coverage in the library. Ideally, in every PR.
|
I see the PR was marked as draft later... If it's not ready for review yet, please ignore my remarks. |
Thx for a quick review! Yeah, still an early draft trying to move things forward. |
d2cd41a to
0154364
Compare
01797f9 to
3e808a9
Compare
ee5b77b to
bc628b4
Compare
9e33a9f to
099a18a
Compare
8368745 to
9a12cc8
Compare
16ab6c4 to
f3c48d2
Compare
f3888c3 to
244b0cf
Compare
c565020 to
79ba4bc
Compare
79ba4bc to
d1013f7
Compare
a71bfed to
2032363
Compare
8b9242e to
5c04a63
Compare
| // Construct a proposal | ||
|
|
||
| // Construct a TON transaction to grant a role |
There was a problem hiding this comment.
Ah, just section titles. Feel free to ignore
|
ecPablo
left a comment
There was a problem hiding this comment.
Last comments for me and I think we should be good to merge.
| run: | | ||
| ./e2e/tests/solana/compile-mcm-contracts.sh | ||
| - name: Build TON contracts |
There was a problem hiding this comment.
I'd prefer to leave out nix on CI and keep just for dev purposes as optional tool, since a lot of devs here are not familiar with the nix ecosystem. I see a couple options:
- Could we either built the artifacts on nix and commit them instead to speed up CI and avoid having to install nix for all e2e tests.
- If removing nix is too much work, maybe we can split this workflow into a separate file and we keep the TON team as codeowners.
cc @gustavogama-cll and @jkongie as you also had some thoughts on this topic.
| github.com/smartcontractkit/chainlink-ccip/chains/solana/gobindings v0.0.0-20250805210128-7f8a0f403c3a | ||
| github.com/smartcontractkit/chainlink-sui v0.0.0-20251104205009-00bd79b81471 | ||
| github.com/smartcontractkit/chainlink-testing-framework/framework v0.12.1 | ||
| github.com/smartcontractkit/chainlink-ton v0.0.0-20251229193709-08e5eefac63c |
There was a problem hiding this comment.
we need to make sure this is a merged commit and not from a PR as we have a check in CI that prevents merging commit that are not on default branch.
No description provided.