リファクタリングのサンプル実装 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hirokinoue
commented
Mar 16, 2025
- 先日会話したリファクタリングのサンプル実装です。closeしていただいて構いません。
- 要点は2つです。
- NodeFinderを利用するようにした。
- Function_とClassMethodを個別に分析する代わりにFunctionLikeを分析するようにした。
- 処理がシンプルになるのと引き換えに、解析結果にクラス名が出力されないようになっており、クラス名を出力する仕様を維持するにはもう一工夫必要です。
- FunctionLikeを分析対象とする場合、その具象に応じたテストケースを追加するのが望ましいと思います。（テストの追加は未実施です）
hirokinoue
commented
Mar 16, 2025
src/Parse/VariableParser.php
Outdated
| { | ||
| $foundFunctions = $this->getFunctions($stmts); | ||
| return array_map(function (FunctionLike $function) { | ||
| $functionIdentifier = $function->name->name ?? $function->getType() . '@' . $function->getStartLine(); |
There was a problem hiding this comment.
関数名がない場合に便宜的な名前をつけるようにしています。
hirokinoue
commented
Mar 16, 2025
test/VariableParserTest.php
Outdated
Comment on lines
41
to
42
| // $this->assertEquals('Clazz::bigFunction', $functions[0]->name); | ||
| $this->assertEquals('bigFunction', $functions[0]->name); |
There was a problem hiding this comment.
クラス名が出力されなくなったことをテストに反映しました。クラス名の出力を維持する場合、元に戻す必要があります。
|
@hirokinoue |
smeghead
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.