Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sfc-gh-abhatnagar
Copy link
Contributor

No description provided.

@sfc-gh-abhatnagar
Copy link
Contributor Author

@sfc-gh-mkeller can you approve this please

Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix what I pointed out, but after that feel free to merge it.

Co-authored-by: Mark Keller <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #558 (d782406) into master (e58cee7) will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   81.70%   81.42%   -0.29%     
==========================================
  Files          57       57              
  Lines        7124     7124              
  Branches     1094     1094              
==========================================
- Hits         5821     5801      -20     
- Misses        983     1005      +22     
+ Partials      320      318       -2     
Impacted Files Coverage Δ
src/snowflake/connector/incident.py 59.74% <0.00%> (-3.90%) ⬇️
src/snowflake/connector/cursor.py 93.34% <0.00%> (-1.88%) ⬇️
src/snowflake/connector/auth.py 78.06% <0.00%> (-1.12%) ⬇️
src/snowflake/connector/converter.py 85.79% <0.00%> (-0.57%) ⬇️
src/snowflake/connector/connection.py 93.68% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e58cee7...d782406. Read the comment docs.

@sfc-gh-abhatnagar sfc-gh-abhatnagar merged commit 7e1778f into master Dec 15, 2020
@sfc-gh-abhatnagar sfc-gh-abhatnagar deleted the SNOW-236836_fix-release-notes branch December 15, 2020 17:29
sfc-gh-aling pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants