Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

sfc-gh-mkeller
Copy link
Collaborator

SNOW-265864

Adding CODEOWNERS

@@ -0,0 +1 @@
* @snowflakedb/Client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this add everyone on the team as a code owner and therefore as a code reviewer on PRs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I thought that wasn't the best idea either, but this is what has been done in our other repos.

Do you think that we should add individual owners to repositories?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea so it adds a lot of noise. Emails are already noisy and so I use https://github.com/pulls/review-requested to be able to really tell which reviews I need to take a serious look at. With this change, I'm getting included on all sorts of reviews and its not super clear which ones I really need to take a look at. Having individuals as code owners could work and when an individual picks up a driver they can send a change to this file to add their name. Similarly when they leave they can send a PR to remove their name from this list. Its slightly more work, but it would be distributed to the individual and this shouldn't get updated too often

@sfc-gh-mkeller sfc-gh-mkeller merged commit f0613f6 into master Jan 19, 2021
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller-SNOW-265864-codeowners branch January 19, 2021 22:22
sfc-gh-aling pushed a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants