Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6.5.3
Choose a base ref
...
head repository: socketio/engine.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6.5.4
Choose a head ref
  • 6 commits
  • 8 files changed
  • 1 contributor

Commits on Nov 9, 2023

  1. refactor: remove useless reference 

    A reference to the initial IncomingMessage object (the first HTTP
request of the session) is kept in memory by default (`socket.request`),
so its attached ServerResponse object (`req.res`) would not be
garbage-collected. This will now be the case.

Note: the IncomingMessage object is needed in two cases:

- when working with the `express-session` middleware (`request.session`)
- when fetching the certificate of the client with `request.socket.getPeerCertificate()`

That's why removing it would be a breaking change.
    @darrachequesne
    darrachequesne committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f27a6c3 View commit details
    Browse the repository at this point in the history

  2. refactor: remove useless references 

    Those timers are only used during the upgrade, so there is no need to
keep those references in memory.
    @darrachequesne
    darrachequesne committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3b5e79e View commit details
    Browse the repository at this point in the history

  3. refactor: simplify code

    @darrachequesne
    darrachequesne committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    43c1c1c View commit details
    Browse the repository at this point in the history

  4. refactor: minor cleanups

    @darrachequesne
    darrachequesne committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    39937f8 View commit details
    Browse the repository at this point in the history

  5. ci: add Node.js 20 in the test matrix 

    Reference: https://github.com/nodejs/Release
    @darrachequesne
    darrachequesne committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    09acb17 View commit details
    Browse the repository at this point in the history

  6. chore(release): 6.5.4 

    Diff: 6.5.3...6.5.4
    @darrachequesne
    darrachequesne committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ff0fbfb View commit details
    Browse the repository at this point in the history
Loading