Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jackhaibo
Copy link
Contributor

What this PR does / why we need it:
Implementation of oceanstor file share driver. All basic functions are completed, waiting to dock with the dock.

Special notes for your reviewer:
@Shruthi-1MN @xxwjj, @wisererik, @leonwanghui, @xing-yang , @NajmudheenCT, @ kumarashit , @rhsakarpos, @himanshuvar, @skdwriting @PravinRanjan10

@skdwriting
Copy link
Collaborator

@jackhaibo, please rebase and update the PR.

@jackhaibo jackhaibo changed the title [WIP] Oceanstor file driver Oceanstor file driver May 31, 2019
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #682 into development will decrease coverage by 1.67%.
The diff coverage is 6.02%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #682      +/-   ##
===============================================
- Coverage        33.12%   31.44%   -1.68%     
===============================================
  Files               77       82       +5     
  Lines            14003    14928     +925     
===============================================
+ Hits              4638     4694      +56     
- Misses            8681     9544     +863     
- Partials           684      690       +6
Impacted Files Coverage Δ
pkg/dock/discovery/discovery.go 31.13% <ø> (ø) ⬆️
pkg/controller/controller.go 31.92% <0%> (-0.1%) ⬇️
.../drivers/filesharedrivers/oceanstor/oceanclient.go 0% <0%> (ø)
...ib/drivers/filesharedrivers/oceanstor/oceanstor.go 0% <0%> (ø)
contrib/drivers/filesharedrivers/oceanstor/nfs.go 0% <0%> (ø)
contrib/drivers/filesharedrivers/oceanstor/cifs.go 0% <0%> (ø)
pkg/db/drivers/etcd/etcd.go 28.03% <0%> (-0.08%) ⬇️
contrib/drivers/filesharedrivers/oceanstor/util.go 78.87% <78.87%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33266d4...4c25cd4. Read the comment docs.

@leonwanghui leonwanghui added the feature there is a huge framework change or feature addition label May 31, 2019
@leonwanghui leonwanghui added this to the Capri RC milestone May 31, 2019
Copy link
Collaborator

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonwanghui leonwanghui merged commit beaeccf into sodafoundation:development Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature there is a huge framework change or feature addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants