Upload and Download of Prometheus configuration file #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@skdwriting @wisererik @xing-yang Please review |
Contributor
Author
|
This is tested for Prometheus, am now extending it to the other 3rd party components too...that is a WIP |
xing-yang
reviewed
May 2, 2019
leonwanghui
reviewed
May 5, 2019
1. renamed receiver to f from this 2. renamed path and conf constants to CamelCase
leonwanghui
reviewed
May 6, 2019
Collaborator
leonwanghui
left a comment
There was a problem hiding this comment.
I mean can you move the code in fileops.go to metrics.go. Because downloadconf and uploadconf is subpath under metrics.
xing-yang
reviewed
May 6, 2019
leonwanghui
reviewed
May 7, 2019
Collaborator
leonwanghui
left a comment
There was a problem hiding this comment.
Please refer to the comments in #708.
Contributor
Author
refactored, moved into metrics.go |
Collaborator
|
Please rebase it. |
Contributor
Author
Done |
leonwanghui
requested changes
May 8, 2019
leonwanghui
requested changes
May 8, 2019
Collaborator
|
Also need a rebase. |
Update README.md
- added . in header copyright line
leonwanghui
requested changes
May 9, 2019
Collaborator
|
@wisererik Please take a look at this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enables us to
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #NA
Special notes for your reviewer:
The similar API is going to be used to upload and download configuration files for all telemetry 3rd party components, like Prometheus, Alert manager, Node exporter etc. The general flow is as below
Upload
Release note:
Upload API
Download API