POST API to collect metrics and send to registered adapters #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@xing-yang @leonwanghui @skdwriting Please review, thanks. |
xing-yang
reviewed
May 9, 2019
Collaborator
|
Please rebase and fix CI failures. |
Development
…id with "--" and we store with "-"
Contributor
Author
|
/retest |
xing-yang
reviewed
May 11, 2019
leonwanghui
reviewed
May 13, 2019
Collaborator
|
Please address the conflict error. |
leonwanghui
requested changes
May 13, 2019
Contributor
Author
|
/retest |
Contributor
Author
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This enables us to collect metrics for a volume from the metrics LVM driver and send them to registered adapters (KAFKA, Prometheus or any 3rd party)
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #NA
Special notes for your reviewer:
NA
Release note:
POST API
REQUEST BODY