AccessApi for fileshare POST, GET , PUT, DELETE #732
Conversation
wisererik
left a comment
There was a problem hiding this comment.
please use lowercase in error log
pkg/api/controllers/fileshare.go
Outdated
| } | ||
| // Unmarshal the request body | ||
| if err := json.NewDecoder(f.Ctx.Request.Body).Decode(&fileshareacl); err != nil { | ||
| reason := fmt.Sprintf("Parse fileshare access rules request body failed: %s", err.Error()) |
testutils/collection/data.go
Outdated
| BaseModel: &model.BaseModel{ | ||
| Id: "d2975ebe-d82c-430f-b28e-f373746a71ca", | ||
| }, | ||
| Description: "This is a sample fileshare for testing", |
|
@PravinRanjan10 It looks like you created a new repo under the opensds org by accident: https://github.com/opensds/AccessApi. I'm going to delete that repo. Please save your work. |
Yeah..To just have backup the code i have created. You may delete it. I have backup in local machine. Thanks |
|
Ok. Will do. Thanks. |
pkg/db/drivers/etcd/etcd.go
Outdated
|
|
||
| func (c *Client) CreateFileShare(ctx *c.Context, fshare *model.FileShareSpec) (*model.FileShareSpec, error) { | ||
| //profiles, err := c.ListProfiles(ctx) | ||
| //if err != nil { |
| _, err := db.C.GetFileShare(ctx, in.FileShareId) | ||
| if err != nil { | ||
| log.Error("FileshareID is not valid: ", err) | ||
| return nil, err |
There was a problem hiding this comment.
FilesareID -> file share id
xing-yang
left a comment
There was a problem hiding this comment.
Please rebase. After that, this can be merged.
| uuid "github.com/satori/go.uuid" | ||
| ) | ||
|
|
||
| //function to store filesahreAcl metadata into database |
There was a problem hiding this comment.
nit: add space after //
What this PR does / why we need it:
It stores the metadata of access rule for fileshare based
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: