Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Shrink size of hotpot binary files #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leonwanghui merged 1 commit into from
May 10, 2019
Merged

Shrink size of hotpot binary files #733

leonwanghui merged 1 commit into from
May 10, 2019

Conversation

@leonwanghui
Copy link
Collaborator

@leonwanghui leonwanghui commented May 10, 2019

Signed-off-by: leonwanghui [email protected]

What this PR does / why we need it:
Currently it's too large for the size of hotpot built binary files, see below:

root@***:~/workspace/gopath/src/github.com/opensds/opensds# ls -lht build/out/bin/
total 78M
-rwxr-xr-x 1 root root 15M May  9 16:18 osdsctl
-rwxr-xr-x 1 root root 23M May  9 16:18 osdsapiserver
-rwxr-xr-x 1 root root 20M May  9 16:18 osdslet
-rwxr-xr-x 1 root root 22M May  9 16:18 osdsdock

But with -ldflags '-w -s' flag, we can shrink them a lot (see below):

root@***:~/workspace/gopath/src/github.com/opensds/opensds# ls -lht build/out/bin/
total 57M
-rwxr-xr-x 1 root root 11M May 10 03:59 osdsctl
-rwxr-xr-x 1 root root 17M May 10 03:59 osdsapiserver
-rwxr-xr-x 1 root root 14M May 10 03:59 osdslet
-rwxr-xr-x 1 root root 16M May 10 03:59 osdsdock

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@leonwanghui leonwanghui added the patch there is minor code change label May 10, 2019
@leonwanghui leonwanghui self-assigned this May 10, 2019
@coveralls
Copy link

coveralls commented May 10, 2019

Coverage Status

Coverage remained the same at 30.262% when pulling c9a0d3d on leonwanghui:bshrink into e803739 on opensds:development.

wisererik
wisererik approved these changes May 10, 2019
View reviewed changes
Copy link
Collaborator

@wisererik wisererik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonwanghui leonwanghui merged commit 7e706f1 into sodafoundation:development May 10, 2019
@leonwanghui leonwanghui deleted the bshrink branch May 10, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wisererik wisererik wisererik approved these changes

Assignees

@leonwanghui leonwanghui

Labels

patch there is minor code change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leonwanghui @coveralls @wisererik