Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Shruthi-1MN
Copy link
Contributor

What this PR does / why we need it:
NFS Driver FileshareAcl AccessTo is limited to one user

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #803 into development will not change coverage.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #803   +/-   ##
============================================
  Coverage        33.12%   33.12%           
============================================
  Files               77       77           
  Lines            14003    14003           
============================================
  Hits              4638     4638           
  Misses            8681     8681           
  Partials           684      684
Impacted Files Coverage Δ
pkg/controller/controller.go 32.01% <0%> (ø) ⬆️
pkg/api/controllers/fileshare.go 15.67% <0%> (ø) ⬆️
osdsctl/cli/fileshareacl.go 74.32% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b69d229...21b9bbb. Read the comment docs.

@Shruthi-1MN Shruthi-1MN force-pushed the nfsdriver-acl-patch branch from 28c07ed to 6062f31 Compare May 31, 2019 16:02
Copy link
Collaborator

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all these binary files

@Shruthi-1MN Shruthi-1MN force-pushed the nfsdriver-acl-patch branch 2 times, most recently from 73b4742 to 91b3bec Compare June 1, 2019 07:58
@Shruthi-1MN Shruthi-1MN force-pushed the nfsdriver-acl-patch branch from 91b3bec to 21b9bbb Compare June 1, 2019 07:59
@Shruthi-1MN
Copy link
Contributor Author

Please remove all these binary files

Removed

Copy link
Collaborator

@leonwanghui leonwanghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonwanghui leonwanghui merged commit 33266d4 into sodafoundation:development Jun 1, 2019
@Shruthi-1MN Shruthi-1MN deleted the nfsdriver-acl-patch branch July 8, 2019 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants