Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix slcli lock replica-failback #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
allmightyspiff opened this issue Dec 17, 2019 · 1 comment
Closed

fix slcli lock replica-failback #1199

allmightyspiff opened this issue Dec 17, 2019 · 1 comment
Assignees
@FernandoOjeda
Labels
API Bug

Comments

@allmightyspiff
Copy link
Member

allmightyspiff commented Dec 17, 2019 •
edited
Loading

BAD

$ slcli -v block replica-failback 41442919
Calling: SoftLayer_Network_Storage::failbackFromReplicant(id=41442919, mask='', filter='None', args=(None,), limit=None, offset=None))

GOOD

slcli -v  call-api SoftLayer_Network_Storage failbackFromReplicant --id=6548079
Calling: SoftLayer_Network_Storage::failbackFromReplicant(id=6548079, mask='', filter='{}', args=(), limit=None, offset=None))

failbackFromReplicant doesn't accept parameters, so that needs to be changed in the manager.

failoverToReplicant doesn't take an immediate parameter either, which the manager is sending. So that hsould be fixed.
@FernandoOjeda FernandoOjeda self-assigned this Dec 17, 2019
@FernandoOjeda FernandoOjeda mentioned this issue Dec 17, 2019
Merged
@allmightyspiff allmightyspiff mentioned this issue Dec 20, 2019
Merged
@allmightyspiff
Copy link
Member Author

Fixed in #1200 and #1204

@allmightyspiff allmightyspiff mentioned this issue Jan 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FernandoOjeda FernandoOjeda

Labels
API Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@allmightyspiff @FernandoOjeda