Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix block storage failback and failover. #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

FernandoOjeda
Copy link
Contributor

Fix block storage failback and failover #1199.

@FernandoOjeda
Copy link
Contributor Author

FernandoOjeda commented Dec 18, 2019

@allmightyspiff I ran the tox analysis for the master softlayer python without changing anything and I got the same error that the travis, could you check it please.

Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change you have look good, but can you do the same for the file CLI/manager bits. Looks like they have the exact same problem as well.

@allmightyspiff
Copy link
Member

I fixed the flake8 tests in #1201 , trying to rebuild now.

@allmightyspiff allmightyspiff merged commit df7df4c into softlayer:master Dec 20, 2019
@allmightyspiff
Copy link
Member

Since i'm going to do a release now, I'm merging this in. Could you fix up the file parts in another pull request. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants