Functionality for VolumeLimit per DataCenter #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allmightyspiff
requested changes
Jan 13, 2020
There was a problem hiding this comment.
Change the CLI command to limits, as limit implies to me the ability to modify the limit. where limits would be to show all the current limits.
Need to fix the tox -e analysis complaints as well, but those are all pretty minor.
analysis run-test: commands[0] | flake8 SoftLayer tests
SoftLayer/CLI/file/limit.py:32:20: W292 no newline at end of file
SoftLayer/CLI/block/limit.py:32:20: W292 no newline at end of file
tests/CLI/modules/file_tests.py:670:5: E303 too many blank lines (2)
tests/managers/block_tests.py:942:81: E231 missing whitespace after ','
|
Added the changes @allmightyspiff needed. Thanks. |
allmightyspiff
approved these changes
Jan 13, 2020
|
Looks good. Thanks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature/VolumeLimit Added the functionality for Volume Limit per Datacenter.