issue#1210 file block storage - adding new feature to list, assign, a… #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd remove subnets from/to ACL host record.
allmightyspiff
requested changes
Jan 23, 2020
There was a problem hiding this comment.
Thanks for the pull request. Over all the code looks fine, just a few style changes needed I think.
- Are these feature not relevant to File storage? If so, would be a good idea to add the corresponding File commands as well.
- use the
string.format()style for adding variables into strings in yourclick.echostatements. - Need a bit of information on how to get
access_id, either in the docblock comment or maybe another command that will print those out? - in the manager make sure to either check or cast
subnets_idto a list so anyone using the manager directly wont have their API call fail.
|
Made changes requested. See new help display: |
allmightyspiff
requested changes
Jan 27, 2020
| assigned_subnets = block_manager.assign_subnets_to_acl(access_id, subnet_ids) | ||
|
|
||
| for subnet in assigned_subnets: | ||
| message = "{0}".format("Successfully assigned subnet id: " + str(subnet) + |
There was a problem hiding this comment.
should be this:
click.echo("Successfully assigned subnet id: {} to allowed host id: {}.".format(subnet, access_id)).format() will substitute in order, so for simple strings like this you don't really need to number/name the substitution brackets. But its certainly fine if you want to be verbose.
|
https://sldn.softlayer.com/reference/datatypes/SoftLayer_Account/#iscsiisolationdisabled needs to be False(ISCSI Isolation enabled for the account) for the new commands to work. |
…led for new commands to work.
allmightyspiff
approved these changes
Jan 28, 2020
|
Fixes #1210 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Feature - support subnet ACL management through cli