Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed Description and some features are missing in slcli block snapshot-set-notification, slcli block subnets-assign, slcli block subnets-list, slcli block subnets-remove #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2023
Merged

Fixed Description and some features are missing in slcli block snapshot-set-notification, slcli block subnets-assign, slcli block subnets-list, slcli block subnets-remove #2047

merged 3 commits into from
Jul 24, 2023

Conversation

ramkishor-ch
Copy link
Contributor

Hi @allmightyspiff,

Fixes: #2014

Title:
Fixed Description and some features are missing in slcli block snapshot-set-notification, slcli block subnets-assign, slcli block subnets-list, slcli block subnets-remove

Description:
I have added Example text in the commands like...
1.
a. The set_volume_snapshot_notification(volume_id, enable) API is returning empty value, because of that confirmation message "Snapshots space usage threshold warning notification has bee set to %s for volume %s" is not getting displayed, so I have removed the if status: line of code.
b. The problem: ./slcli block snapshot-set-notification will be fixed in this issue: #2046.

Expected:

./slcli block snapshot-set-notification --help
Usage: slcli block snapshot-set-notification [OPTIONS] VOLUME_ID

        Enables/Disables snapshot space usage threshold warning for a given volume.

┌────┬───────────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│    │ volume_id │                                                                                                                            │
│    │ --enable/--disable │ Enable/Disable snapshot notification. Use `slcli block snapshot-set-notification volumeId --enable` to enable.  [required] │
│ -h │ --help    │ Show this message and exit.                                                                                                │
└────┴───────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
  1. Added Example message in ./slcli block subnets-assign --help
  2. Added Example message in ./slcli block subnets-list --help
  3. Added Example message in ./slcli block subnets-remove --help

Please find the screenshots for reference.

Screen Shots:
1, 2, 3, 4:
Screenshot 2023-07-18 at 8 23 54 PM

Thanks,
Ramkishor Chaladi.

Ramkishor Chaladi added 2 commits July 18, 2023 20:13
@ramkishor-ch ramkishor-ch self-assigned this Jul 18, 2023
allmightyspiff
allmightyspiff requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the documentation changes you made, keep the description first, and use 2 :: to mark the Example:: line

@ramkishor-ch
Copy link
Contributor Author

Hi @allmightyspiff,

As suggested, I updated the changes, please review it.

Screen Shot:
Screenshot 2023-07-19 at 1 55 40 PM

Thanks,
Ramkishor Chaladi.

@allmightyspiff allmightyspiff merged commit 029e87d into softlayer:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

Assignees

@ramkishor-ch ramkishor-ch

Labels
CLI
Projects
No open projects
Q3 2023
Status: ✅ Done
Milestone
No milestone
2 participants
@ramkishor-ch @allmightyspiff