Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate v1 and v2 transactions#1545

Merged
franciszekjob merged 78 commits into
developmentfrom
franciszekjob/1540-txs-deprecation
Jan 13, 2025
Merged

Deprecate v1 and v2 transactions#1545
franciszekjob merged 78 commits into
developmentfrom
franciszekjob/1540-txs-deprecation

Conversation

@franciszekjob

@franciszekjob franciszekjob commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator

Closes #1540

Introduced changes

Deprecate v1 and v2 transactions:

  • Remove docs examples including/mentioning these versions
  • Mark v1 and v2 methods/classes as deprecated in docs
  • Display deprecation warning when using these methods

  • This PR contains breaking changes

@ddoktorski ddoktorski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos in the title v2 and v3 -> v1 and v2

Comment thread starknet_py/utils/deprecation.py
Comment thread starknet_py/utils/deprecation.py Outdated
Comment thread starknet_py/tests/e2e/fixtures/accounts.py Outdated
@franciszekjob franciszekjob changed the title Deprecate v2 and v3 transactions Deprecate v1 and v2 transactions Jan 10, 2025
@franciszekjob

Copy link
Copy Markdown
Collaborator Author

Typos in the title v2 and v3 -> v1 and v2

Oops, right 😅

@franciszekjob franciszekjob changed the base branch from franciszekjob/python3.9-as-minimum-version to development January 10, 2025 14:27
Comment thread starknet_py/tests/e2e/docs/guide/test_declaring_contracts.py Outdated
Comment thread starknet_py/tests/e2e/docs/guide/test_declaring_contracts.py Outdated
@franciszekjob franciszekjob merged commit 2478a6c into development Jan 13, 2025
@franciszekjob franciszekjob deleted the franciszekjob/1540-txs-deprecation branch January 13, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate txs versions other than v3

2 participants