Sherrboldt/TOUGH-updates #111
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me, reading FOFT and GOFT files (WIP)
… PI/II calculation
…rid of errors. Ran into an error when reading FOFT files, possibly an issue on TOUGH's end.
… size to 5 or reservoirthickness/5, this is more inline with the original. Was calculating PI/II in kg/s/kPa when it should be kg/s/bar. In WellBores.py, "def get_hydrostatic_pressure_kPa" used the parameter "gradient_C_per_km" when the actual float value was in C/m. Changed parameter "gradient_C_per_km" to "gradient_C_per_m".
…I/II from kg/s/kPa to kg/s/bar
…d deletion of example6.out
src/geophires_x/WellBores.py
Outdated
| Tsurf_degC: float, | ||
| depth_m: float, | ||
| gradient_C_per_km: float, | ||
| gradient_C_per_m: float, # converted from C/km to C/m |
Owner
Author
There was a problem hiding this comment.
TODO: verify
Owner
Author
There was a problem hiding this comment.
TODO: Probable bug in overpressure
Comment on lines
+50
to
+59
| self.injection_cell = self.ParameterDict[self.injection_cell.Name] = strParameter( | ||
| "Vertical Injection Well Cell ID", | ||
| DefaultValue='A3Q23', | ||
| UnitType=Units.NONE, | ||
| ) | ||
| self.production_cell = self.ParameterDict[self.production_cell.Name] = strParameter( | ||
| "Vertical Production Well Cell ID", | ||
| DefaultValue='A3Q28', | ||
| UnitType=Units.NONE, | ||
| ) |
Owner
Author
There was a problem hiding this comment.
TODO: tooltip texts
Comment on lines
+72
to
+130
| self.hrz_inj1 = self.ParameterDict[self.hrz_inj1.Name] = strParameter( | ||
| "Horizontal Injection Well Cell ID 1", | ||
| DefaultValue='A3R23', | ||
| UnitType=Units.NONE, | ||
| ) | ||
| self.hrz_inj2 = self.ParameterDict[self.hrz_inj2.Name] = strParameter( | ||
| "Horizontal Injection Well Cell ID 2", | ||
| DefaultValue='A3S23', | ||
| UnitType=Units.NONE, | ||
| ) | ||
| self.hrz_inj3 = self.ParameterDict[self.hrz_inj3.Name] = strParameter( | ||
| "Horizontal Injection Well Cell ID 3", | ||
| DefaultValue='A3T23', | ||
| UnitType=Units.NONE, | ||
| ) | ||
| self.hrz_inj4 = self.ParameterDict[self.hrz_inj4.Name] = strParameter( | ||
| "Horizontal Injection Well Cell ID 4", | ||
| DefaultValue='A3U23', | ||
| UnitType=Units.NONE, | ||
| ) | ||
| self.hrz_inj5 = self.ParameterDict[self.hrz_inj5.Name] = strParameter( | ||
| "Horizontal Injection Well Cell ID 5", | ||
| DefaultValue='A3V23', | ||
| UnitType=Units.NONE, | ||
| ) | ||
| self.numhprodcell = self.ParameterDict[self.numhprodcell.Name] = intParameter( | ||
| "Number of Horizontal Production Well Cells", | ||
| DefaultValue=0, | ||
| AllowableRange=[0, 1, 2, 3, 4, 5], | ||
| UnitType=Units.NONE, | ||
| Required=True, | ||
| ErrMessage="Assume no horizontal production well", | ||
| ToolTipText="Number of cells assumed as horizontal production wells" | ||
| ) | ||
| self.hrz_prod1 = self.ParameterDict[self.hrz_prod1.Name] = strParameter( | ||
| "Horizontal Production Well Cell ID 1", | ||
| DefaultValue='A3R28', | ||
| UnitType=Units.NONE, | ||
| ) | ||
| self.hrz_prod2 = self.ParameterDict[self.hrz_prod2.Name] = strParameter( | ||
| "Horizontal Production Well Cell ID 2", | ||
| DefaultValue='A3S28', | ||
| UnitType=Units.NONE, | ||
| ) | ||
| self.hrz_prod3 = self.ParameterDict[self.hrz_prod3.Name] = strParameter( | ||
| "Horizontal Production Well Cell ID 3", | ||
| DefaultValue='A3T28', | ||
| UnitType=Units.NONE, | ||
| ) | ||
| self.hrz_prod4 = self.ParameterDict[self.hrz_prod4.Name] = strParameter( | ||
| "Horizontal Production Well Cell ID 4", | ||
| DefaultValue='A3U28', | ||
| UnitType=Units.NONE, | ||
| ) | ||
| self.hrz_prod5 = self.ParameterDict[self.hrz_prod5.Name] = strParameter( | ||
| "Horizontal Production Well Cell ID 5", | ||
| DefaultValue='A3V28', | ||
| UnitType=Units.NONE, | ||
| ) |
Owner
Author
There was a problem hiding this comment.
TODO: tooltip texts
Comment on lines
+263
to
+276
| print('Reservoir parameters passed to TOUGH from Reservoir.py \n') | ||
| print("Initial Temperature = ", initialtemp) | ||
| print("Rock Density = ", rockdensity) | ||
| print("Roch Heat Capacity = ", rockheatcap) | ||
| print("Rock Permeability = ", rockperm) | ||
| print("Rock Porosity = ", rockpor) | ||
| print("Rock Thermal Conductivity = ", rockthermalcond) | ||
| print("Reservoir Thickness = ", reservoirthickness) | ||
| print("Reservoir Width = ", reservoirwidth) | ||
| print("Well Separation = ", wellseperation) | ||
| print("Grid X = ", DeltaXgrid) | ||
| print("Grid Y = ", DeltaYgrid) | ||
| print("Grid Z = ", DeltaZgrid) | ||
| print("") |
Owner
Author
There was a problem hiding this comment.
TODO: should be log statements instead of prints
Comment on lines
-211
to
+369
| outfile = str('tough2output.out') | ||
| outfile = str('Doublet.out') |
Owner
Author
There was a problem hiding this comment.
TODO: probably arbitrary and should be reverted, but might be TOUGH2 vs. TOUGH3 naming change requiring parameterization/conditionalization
Owner
Author
softwareengineerprogrammer
left a comment
There was a problem hiding this comment.
High-level tasks (in addition to comments):
- Verify existing example5/example6 cases pass (and haven't been backwards-incompatibly broken)
- Review parameterization schema to ensure it's appropriately generic (e.g. single production/injection cell IDs, 6 horizontals, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from https://github.com/SHerrboldt/GEOPHIRES-X/tree/TOUGH-updates
Instructions for @SHerrboldt:
git checkout maingit pullgit remote add softwareengineerprogrammer [email protected]:softwareengineerprogrammer/GEOPHIRES.gitgit fetch softwareengineerprogrammergit checkout softwareengineerprogrammer/softwareengineerprogrammer_sherrboldt_tough-updatesgit checkout -b TOUGH-updates-2git push -u <your remote, possibly fork or SHerrboldt> TOUGH-updates-2git pushand then create PR from SHerrboldt/TOUGH-updates-2 to SHerrboldt/main, then notify @softwareengineerprogrammer (me).