[pull] main from garrytan:main#107
Merged
Merged
Conversation
…-holding orphans proc.kill() only signals the sh -c wrapper; the claude child survives as an orphan that inherited our stdout/stderr pipes, blocking the stream drain until it exits (observed: a 600s spawn timeout stretching to 1431s and tripping bun's per-test timeout with no result). On timeout, cancel the stdout reader; race the stderr drain against child exit + 5s grace. Streamed transcript lines survive the cancel, so callers still get their evidence. Regression test: test/session-runner-timeout.test.ts (fake claude spawns a pipe-holding orphan; fails in 30s without the fix, passes in 8s with it). Co-Authored-By: Claude Fable 5 <[email protected]>
…read real stream-json Root cause of months of silent local failure: the sandbox copied skill dirs to the repo root, but claude >= 2.x resolves slash commands strictly from registered skills, so /autoplan short-circuited with 'Unknown command' (0 turns, ~1s) on every attempt. Install /autoplan + review skills at project-level .claude/skills/ (same pattern as skill-routing-e2e). Also: the transcript filter matched entry.type === 'tool_use', a shape that never appears at the top level of raw stream-json, so assertions only ever saw the final result text; filter on assistant/user events instead. Hang protection accepts the Phase 1 review dispatch (Agent/Task tool call carrying review instructions) as progress evidence, since full Phase 1 completion is 15+ min of subagent work. Budget raised to 10 min / 40 turns. Invisible in CI: the file is in neither evals.yml nor evals-periodic.yml matrices (coverage decision filed in TODOS.md). Co-Authored-By: Claude Fable 5 <[email protected]>
…coverage decision Co-Authored-By: Claude Fable 5 <[email protected]>
Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )