Fix - release signing - #467
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the sign_release GitHub Actions job so that signed JARs are not overwritten by a subsequent rebuild before being uploaded to the GitHub Release.
Changes:
- Removed the redundant standalone
./gradlew clean build -x teststep fromsign_release. - Moved the
./.github/actions/versionstep to run before the signing step so signing is the last build-affecting operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Fixes the release signing job so that signed JARs are not overwritten before upload.
Details
The
sign_releasejob had the "Set agent version" step running after the signing step. That version action calls./gradlew build -x testto extract the version from the built JAR's manifest, which rebuilds the agent and overwrites the signed JARs with unsigned ones. The uploaded artifacts were therefore never actually signed.The fix removes the redundant standalone build step and moves the version action to run before signing. This ensures the signing step is the last operation to touch the JARs before upload.
Test services data