New - use new config for jfr metrics - #474
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the SolarWinds OpenTelemetry distro’s default agent properties to use the newer runtime telemetry configuration intended to enable JFR-related (experimental) metrics emission.
Changes:
- Replaced the legacy
otel.instrumentation.runtime-telemetry-java17.enabled=trueproperty withotel.instrumentation.runtime-telemetry.emit-experimental-metrics=true.
| @@ -41,7 +41,7 @@ public class SolarwindsPropertiesSupplier implements Supplier<Map<String, String | |||
| PROPERTIES.put( | |||
| "otel.exporter.otlp.metrics.default.histogram.aggregation", | |||
| "base2_exponential_bucket_histogram"); | |||
There was a problem hiding this comment.
This switches the runtime telemetry/JFR-related config key, but the repo still configures runtime-telemetry-java17 elsewhere (e.g., smoke-tests/sdk-config.yaml under instrumentation/development/java/runtime-telemetry-java17). If the upstream agent has renamed/merged this instrumentation, consider updating those configurations (or adding a short comment here) so we don’t end up with two divergent ways of enabling JFR/runtime telemetry metrics.
| "base2_exponential_bucket_histogram"); | |
| "base2_exponential_bucket_histogram"); | |
| // Keep this runtime telemetry/JFR metrics switch aligned with any repo configuration | |
| // that still references the older runtime-telemetry-java17 instrumentation name. |
There was a problem hiding this comment.
Should smoke-tests/sdk-config.yaml also be updated?
ce8a919 to
6bb80d3
Compare
cheempz
left a comment
There was a problem hiding this comment.
LGTM, thanks for the revisit and fingers crossed :)
6bb80d3 to
ddc0d5e
Compare
Test services data