Fix - remove cloud relocation because it's not needed anymore - #476
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the central ShadowJar relocation rules (in buildSrc) to prevent OpenTelemetry semantic convention attribute key corruption caused by an overly broad relocation, while also removing a duplicate relocation entry.
Changes:
- Removed the
cloud→com.solarwinds.joboe.shaded.cloudrelocation that was rewriting semantic attribute names (e.g.,cloud.platform). - Removed a duplicate
com.google→com.solarwinds.joboe.shaded.googlerelocation rule. - Moved the bare
google→com.solarwinds.joboe.shaded.google2relocation to the end of the relocation list for clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
cloudpackage relocation from the shadow JAR configuration and deduplicate thecom.googlerelocation rule.Details
The
cloudrelocation (cloud→com.solarwinds.joboe.shaded.cloud) was inadvertently rewriting OpenTelemetry semantic convention attribute names that containcloud(e.g.,cloud.platform,cloud.provider) into shaded equivalents at build time. This caused the agent to emit incorrect attribute keys at runtime.Removing this relocation fixes the attribute name corruption. No actual classes under a bare
cloud.*package exist in the dependency tree, so the rule served no useful shading purpose.Additionally, the
com.googlerelocation in this block was a duplicate — it already exists earlier in the file. Thegooglerelocation (for proto-generated classes outside thecom.googlenamespace) is retained and moved to the end of the relocation list for clarity.Changes
cloud→com.solarwinds.joboe.shaded.cloudrelocationcom.google→com.solarwinds.joboe.shaded.googlerelocationgoogle→com.solarwinds.joboe.shaded.google2relocation to end of blockTest Plan:
Manual verification
Test services data