Patch 2 #46
Merged
Patch 2 #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oniram22
commented
Dec 27, 2019
- Added add_group_custom_property method
- Added set_group_custom_properties method
- Changed name of set_custom_properties to set_node_custom_property
- Changed name of get_custom_properties to get_node_custom_properties
- Added add_dns_a_record_with_ptr_to_ipam method
- Added add_group_custom_property method - Added set_group_custom_property method - Changed the name of set_custom_properties to set_node_custom_property - Changed the name of get_custom_properties to get_node_custom_properties - Added add_dns_a_record_with_ptr_to_ipam method
danjagnow
reviewed
Jan 3, 2020
Contributor
danjagnow
left a comment
There was a problem hiding this comment.
Looks good! I have one minor parameter-ordering issue that I'd prefer to see changed before merging.
| results = self.swis.create('Orion.IpSla.Operations', **ip_sla_properties) | ||
| self.logger.info("add_icmp_echo_ip_sla_operation_to_node - add IP SLA operation to node create results: %s", results) | ||
|
|
||
| def set_custom_properties(self, node_name, custom_property_name, custom_property_value): |
Contributor
There was a problem hiding this comment.
The method name changes for set_custom_properties and get_custom_properties are breaking changes, but those are better names.
orionsdk/solarwinds.py
Outdated
| report_id = results['results'][0]['PolicyReportID'] | ||
| self.swis.invoke('Cirrus.PolicyReports', 'StartCaching', [report_id]) | ||
|
|
||
| def add_dns_a_record_with_ptr_to_ipam(self, name, ip_address, domain, server): |
Contributor
There was a problem hiding this comment.
For consistency, I'd keep the parameter order the same here as in the invocation below: server then domain.
…ade per your suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.