Add sensor log monitoring with improved configuration support #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xisting plugin configs. New issue raised for DRYing the config validation
…iguration flexibility - Introduced `SensorLogMonitorState` model for tracking monitoring state. - Added monitoring job to alert on missing sensor logs based on configurable thresholds. - Updated `SmibhidSensorPluginConfig` to include monitoring settings. - Enhanced utility module with `get_humanized_timedelta` for user-friendly time outputs. - Adjusted plugin to conditionally enable or disable monitoring based on configuration.
There was a problem hiding this comment.
Pull Request Overview
Implements sensor log monitoring functionality with configurable alerts and improves configuration validation across the codebase.
- Added monitoring job to detect when sensor logs are missing beyond configurable thresholds
- Enhanced configuration system with better error handling and validation
- Introduced timezone-aware database operations for improved reliability
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/smib/utilities/init.py | Adds humanized time delta formatting utility |
| src/smib/plugins/lifecycle_manager.py | Enhanced plugin registration error handling for configuration failures |
| src/smib/db/manager.py | Enables timezone-aware MongoDB operations |
| src/smib/config/_env_base_settings.py | Adds enum parsing and none string handling |
| src/smib/config/init.py | Makes validation error formatter public and updates signature |
| src/plugins/space/spacestate/config.py | Adds configuration validation with proper error handling |
| src/plugins/space/smibhid/sensor/models.py | Adds monitoring state model and latest log query method |
| src/plugins/space/smibhid/sensor/config.py | New configuration class for sensor monitoring settings |
| src/plugins/space/smibhid/sensor/init.py | Implements scheduled sensor log monitoring with Slack alerts |
| src/plugins/space/smibhid/init.py | Updates plugin registration to include scheduler interface |
| SETTINGS.md | Documents new sensor monitoring configuration options |
| README.md | Updates plugin description to mention monitoring feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
@sjefferson99 Ok, I've updated as per the GH Copilot review - all made sense! |
|
@sam57719 Code looks good bar the comment above. I will pull onto smib-dev and confirm I can get it to build and trigger warnings. |
sjefferson99
requested changes
Sep 25, 2025
…dability and reuse - Extracted monitoring logic into helper functions: `_log_monitoring_settings`, `_fetch_latest_log`, `_compute_monitor_flags`, `_send_alert`, and `_update_monitor_state`. - Streamlined sensor monitor setup with `setup_monitor_job` and `setup_routes` for clearer structure. - Improved separation of concerns for better maintainability.
|
Pushed a refactored version |
…ved-within-x-minutes
…ved-within-x-minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SensorLogMonitorStatemodel to track the state of sensor log monitoring.SmibhidSensorPluginConfigto include new monitoring options. (See SETTINGS.md)get_humanized_timedeltafunction for human-readable time differences.tz_aware=TrueforAsyncMongoClientto ensure timezone-aware database operations.