Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bootstrap4 migration#643

Open
fruitizz wants to merge 10 commits into
sorich87:masterfrom
fruitizz:master
Open

Bootstrap4 migration#643
fruitizz wants to merge 10 commits into
sorich87:masterfrom
fruitizz:master

Conversation

@fruitizz
Copy link
Copy Markdown
Collaborator

No description provided.

@marclaporte
Copy link
Copy Markdown
Contributor

@azizmashkour : can you please update to use Bootstrap 4.1?
https://blog.getbootstrap.com/2018/04/09/bootstrap-4-1/

Thank you!

@barryvdh
Copy link
Copy Markdown

barryvdh commented May 1, 2018

Are you having issues with Bootstrap 4.1? Is this fully functional on Bootstrap4?

@BenMaxfield
Copy link
Copy Markdown

have pulled locally and does not work properly with 4.1 in current state. Fails to open anything if only one step, and then even with 2 steps it opens but there is no title or content

@BenMaxfield
Copy link
Copy Markdown

Having had a play with the source, I think the issue for lack of title and content is due to the default template, currently it is

template: '<div class="popover" role="tooltip"> <div class="arrow"></div> <h3 class="popover-title"></h3> <div class="popover-content"></div> <div class="popover-navigation"> <div class="btn-group"> <button class="btn btn-sm btn-secondary" data-role="prev">&laquo; Prev</button> <button class="btn btn-sm btn-secondary" data-role="next">Next &raquo;</button> <button class="btn btn-sm btn-secondary" data-role="pause-resume" data-pause-text="Pause" data-resume-text="Resume">Pause</button> </div> <button class="btn btn-sm btn-secondary" data-role="end">End tour</button> </div> </div>',

but it should be

template: '<div class="popover" role="tooltip"> <div class="arrow"></div> <h3 class="popover-header"></h3> <div class="popover-body"></div> <div class="popover-navigation"> <div class="btn-group"> <button class="btn btn-sm btn-secondary" data-role="prev">&laquo; Prev</button> <button class="btn btn-sm btn-secondary" data-role="next">Next &raquo;</button> <button class="btn btn-sm btn-secondary" data-role="pause-resume" data-pause-text="Pause" data-resume-text="Resume">Pause</button> </div> <button class="btn btn-sm btn-secondary" data-role="end">End tour</button> </div> </div>',

Note I have just changed the classes
popover-title
popover-content

to
popover-header
popover-body

@asseti6
Copy link
Copy Markdown

asseti6 commented Jun 4, 2018

I can confirm that @BenMaxfield solution solves the issue with Bootstrap v4.1+

@peteristhegreat
Copy link
Copy Markdown

@azizmashkour @BenMaxfield @asseti6

Thank you for all of your work that you've done! It helped a ton today for me. I posted a gist that uses all this goodness here:

https://gist.github.com/peteristhegreat/0678620341f6af725b23cd4cd395ec48

@KnpA
Copy link
Copy Markdown

KnpA commented Dec 3, 2018

It is working for me as well. You did an incredible job, thank you !

@fruitizz
Copy link
Copy Markdown
Collaborator Author

fruitizz commented Dec 3, 2018

Thank you all guys, I will definitively recheck and retest all submitted pull requests in the repository then prepare a new version that will contain all new features and fixed issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants