Codestin Search App

RichDom2185 · 2026-04-14T09:45:58Z

Description

The former depends on v8 which doesn't work in React 19. We create our own custom component for now with the same API to minimize downstream dependent changes.

Fixes crashes in pages that depend on it

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Code quality improvements

How to test

Checklist

I have tested this code
I have updated the documentation

…nto react-day-picker-v9

RichDom2185 · 2026-04-14T09:46:16Z

/gemini review

gemini-code-assist

Code Review

This pull request replaces the @blueprintjs/datetime dependency with a custom implementation of DateInput, DatePicker, and TimePicker built using react-day-picker. Feedback highlights several critical issues, including potential application crashes when calling toISOString on invalid dates and missing NaN checks during time parsing. There are also concerns regarding state synchronization in DateInput and DatePicker, logic errors that prevent clearing selections or setting times before a date is picked, and a type mismatch in the DateInput API compared to the component it replaces. Additionally, an unused prop with a TODO comment should be removed or tracked formally.

coveralls · 2026-04-14T09:50:40Z

Coverage Report for CI Build 24393155027

Coverage remained the same at 40.892%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	13800
Covered Lines:	6087
Line Coverage:	44.11%
Relevant Branches:	7006
Covered Branches:	2421
Branch Coverage:	34.56%
Branches in Coverage %:	Yes
Coverage Strength:	28.94 hits per line

💛 - Coveralls

gemini-code-assist

Code Review

This pull request replaces the @blueprintjs/datetime dependency with a custom implementation of date and time pickers using react-day-picker v9. The changes introduce new DateInput, DatePicker, and TimePicker components and update existing references throughout the codebase. Feedback identifies several critical issues: the omission of required CSS for react-day-picker, the use of deprecated component keys in the DatePicker configuration, and state synchronization bugs in DatePicker and DateInput that prevent them from functioning correctly as controlled components. Additionally, improvements are suggested for TimePicker to handle invalid numeric inputs more robustly using Blueprint's onValueChange callback.

Copilot

Pull request overview

This PR removes @blueprintjs/datetime (which depends on react-day-picker v8 and breaks under React 19) and introduces local replacement components backed by react-day-picker v9 to keep the existing API surface mostly intact and prevent downstream changes.

Changes:

Remove @blueprintjs/datetime and add react-day-picker@^9.14.0 dependency updates.
Introduce src/commons/DateTimePickers (DatePicker, TimePicker, DateInput) and switch existing imports to use them.
Remove the Blueprint datetime stylesheet import.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
yarn.lock	Removes Blueprint datetime resolution and adds `react-day-picker@9` (plus new transitive deps).
package.json	Drops `@blueprintjs/datetime`, adds `react-day-picker`.
src/styles/index.scss	Removes Blueprint datetime CSS import.
src/pages/academy/groundControl/subcomponents/GroundControlEditCell.tsx	Switches `DateInput` import to local wrapper.
src/pages/academy/gameSimulator/subcomponents/chapterPublisher/ChapterPublisherEditor.tsx	Switches `DatePicker` import to local wrapper.
src/commons/achievement/control/goalEditor/EditableTime.tsx	Switches `TimePicker` import to local wrapper.
src/commons/achievement/control/goalEditor/EditableDate.tsx	Switches `DatePicker` import to local wrapper.
src/commons/achievement/control/achievementEditor/EditableDate.tsx	Switches `DatePicker` import to local wrapper.
src/commons/DateTimePickers/index.ts	New barrel export for the wrapper components.
src/commons/DateTimePickers/TimePicker.tsx	New custom time picker built on Blueprint `NumericInput`.
src/commons/DateTimePickers/DatePicker.tsx	New calendar picker built on `react-day-picker` with Blueprint UI elements.
src/commons/DateTimePickers/DateInput.tsx	New input+popover wrapper combining `InputGroup` and the custom `DatePicker`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-14T09:51:42Z

+  timePrecision,
+  disableTimezoneSelect
+}) => {
+  void timePrecision;
+  void disableTimezoneSelect;


timePrecision and disableTimezoneSelect are accepted in the public props but explicitly ignored (void ...). Call sites pass these props (e.g. GroundControl) expecting behavior; ignoring them can be a functional regression compared to @blueprintjs/datetime. Either implement the relevant behavior (e.g. hide minutes/seconds based on timePrecision, omit timezone UI when disabled) or remove these props from the API to avoid a misleading interface.

Intentional. This is a temporary migration

sentry · 2026-04-14T10:11:20Z

 import { Dialog, DialogBody, DialogFooter, Intent } from '@blueprintjs/core';
-import { DateInput } from '@blueprintjs/datetime';
 import { IconNames } from '@blueprintjs/icons';
 import dayjs from 'dayjs';
 import React, { useCallback, useState } from 'react';
+import { DateInput } from 'src/commons/DateTimePickers';

 import { AssessmentOverview } from '../../../../commons/assessment/AssessmentTypes';
 import ControlButton from '../../../../commons/ControlButton';


Bug: Clearing the date input in GroundControlEditCell creates an invalid dayjs object that bypasses a !newDate check, leading to a crash or data corruption when .toISOString() is called.
_{Severity: HIGH}

Suggested Fix

In GroundControlEditCell.tsx, enhance the validation within handleDateChange or handleUpdateDate. Instead of just checking for a truthy value with if (!newDate), use if (!newDate || !newDate.isValid()) to properly guard against invalid date objects before attempting to call .toISOString().

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: src/pages/academy/groundControl/subcomponents/GroundControlEditCell.tsx#L1-L8 Potential issue: When a user clears the `DateInput` field, the `onChange` callback is triggered with `null`. In `GroundControlEditCell.tsx`, this results in `dayjs(null)` being called, which creates an invalid but truthy `dayjs` object. A subsequent guard clause, `if (!newDate)`, fails to catch this invalid state. The code then proceeds to call `.toISOString()` on this invalid object. The exact outcome is uncertain, but it will either throw a `RangeError`, causing a crash, or send an invalid date string to the backend, causing data corruption.

Not clearable at the moment, so it's fine

RichDom2185 · 2026-04-14T11:33:19Z

Let's merge this hotfix to get the frontend working again. Proper fix is put in #3779 as an issue.

RichDom2185 added 6 commits April 14, 2026 16:14

Install react-day-picker v9

28b40b3

Change import sources awaiting component implementation

e4d4cbe

Create custom time picker

f6775cf

Create date picker and date input

54d6b23

Remove BlueprintJS datetime

5dd0703

Merge branch 'master' of https://github.com/source-academy/frontend i…

bee7ce5

…nto react-day-picker-v9

RichDom2185 requested a review from Nocaxe April 14, 2026 09:45

RichDom2185 self-assigned this Apr 14, 2026

RichDom2185 requested a review from Copilot April 14, 2026 09:46

Copilot started reviewing on behalf of RichDom2185 April 14, 2026 09:46 View session

gemini-code-assist Bot reviewed Apr 14, 2026

View reviewed changes

sentry Bot reviewed Apr 14, 2026

View reviewed changes

Comment thread src/commons/DateTimePickers/DatePicker.tsx Outdated

Comment thread src/commons/DateTimePickers/DateInput.tsx

Comment thread src/commons/DateTimePickers/DatePicker.tsx

gemini-code-assist Bot reviewed Apr 14, 2026

View reviewed changes

Copilot AI reviewed Apr 14, 2026

View reviewed changes

RichDom2185 added 4 commits April 14, 2026 17:57

Fix bugs

a1a7efe

Fix sync

01ca384

Fix clearing

b0f73b4

Prefer ts-expect error

b44a5cb

sentry Bot reviewed Apr 14, 2026

View reviewed changes

RichDom2185 changed the title ~~Replace @blueprintjs/datetime with react-day-picker v9~~ Hotfix: Replace @blueprintjs/datetime with react-day-picker v9 Apr 14, 2026

RichDom2185 mentioned this pull request Apr 14, 2026

Use proper date picker component #3779

Open

RichDom2185 merged commit 7f6b143 into master Apr 14, 2026
10 checks passed

RichDom2185 deleted the react-day-picker-v9 branch April 14, 2026 11:33

Conversation

RichDom2185 commented Apr 14, 2026

Description

Type of change

How to test

Checklist

Uh oh!

RichDom2185 commented Apr 14, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 24393155027

Coverage remained the same at 40.892%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

RichDom2185 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sentry Bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

RichDom2185 Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

RichDom2185 commented Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

coveralls commented Apr 14, 2026 •

edited

Loading