Rename directories on Windows does not need syscall.Fsync() on rename. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emidoots
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
if we are only doing renames on directories then indeed this should be safe. Otherwise if we are trying to do some sort of atomic file writing maybe it is worth using this package which seems to have support for windows. https://github.com/natefinch/atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows the
os.Renamedoes not require a subsequent call tosyscall.Fsync(). This change avoidERROR_ACCESS_DENIEDas the folder is already opened by the process that extracted the installation.