Mockable I/O#1110
Closed
divergentdave wants to merge 7 commits into
Closed
Conversation
2ff3a3b to
e45f50e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's an initial effort at adding an indirection layer to all I/O, so that it can be mocked or traced. The approach I'm using here is to put a trait object in the Config to handle all top-level filesystem interactions, and to make open file handles trait objects as well. There are currently two sets of implementations for these traits, one for the real operating system, and a simple mock file system for testing. The mocks lean heavily on mutexes for now, concurrent file operations are future work.
stracereports that the test using mocked I/O does not touch the operating system! Tracing is not yet supported, but it would fit naturally as wrapper implementations of the I/O traits. Something in these changes seems to cause a significant performance penalty on the benchmarks, so non-test performance is an open issue too.See also #1077. Some of the changes here also appear in #1108.