fix: getRegister and bit-masks #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original logic would only mask out the sign bit, but leave 4 bits of random data in place. This masks out all 5 bits.
|
There's also this drop-in replacement for getRegister: |
|
Hi Will (@TheRealWaldo ), Thank you for the fix. And apologies for the VERY slow reply! I've added a slightly different fix in v1.0.2 - which will be released shortly. I went with I'm going to close this - but will also give you a mention in the v1.0.2 release notes. Your PR would have worked perfectly - I just did the same thing a different way... Very best wishes, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getRegister was always reading 2 bytes even if 1 was requested, causing most methods to fail.
Further, only the signing bit was masked out on temperature reads, leaving 4 random bits of data in values, causing havoc at high/low readings.