fix: last updates time bug in workspace #349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hey, the Quality Gate has FAILED. 💣Status: ERROR, 💣Status: ERROR, |
SonarQube Quality Gate Result
updated: 3/27/2025, 10:36:31 (UTC+0) |
Astitva877
reviewed
Apr 3, 2025
| @@ -283,6 +283,8 @@ export class collectionController { | |||
| user.name, | |||
| requestDto?.folderId, | |||
| ); | |||
| // update the updateAt timestamp | |||
| await this.workSpaceService.update(workspaceId, {}); | |||
There was a problem hiding this comment.
instead of updating the timestamp here, call workspaceRepository.update inside collectionRequestService.addRequest.
Astitva877
reviewed
Apr 3, 2025
| @@ -316,7 +318,8 @@ export class collectionController { | |||
| requestId, | |||
| requestDto, | |||
| ); | |||
|
|
|||
| // update the updateAt timestamp | |||
| await this.workSpaceService.update(workspaceId, {}); | |||
Astitva877
reviewed
Apr 3, 2025
| @@ -354,7 +357,8 @@ export class collectionController { | |||
| requestDto, | |||
| ); | |||
| const collection = await this.collectionService.getCollection(collectionId); | |||
|
|
|||
| // update the updateAt timestamp | |||
| await this.workSpaceService.update(workspaceId, {}); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add your description here.
Add Issue Number
Fixes #
Add Screenshots/GIFs
If applicable, add relevant screenshot/gif here.
Add Known Issue
If applicable, add any known issues.
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.