Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add min version xarray-dataclasses #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LucaMarconato
Copy link
Collaborator

The spatialdata CI started failing because of an old version of xarray-dataclasses being installed.

xarray-dataclasses is installed by spatial-image, which currently does not put a lower bound for xarray-dataclasses. In this PR I add xarray-dataclasses>=1.8.0 as a lower bound.

I chose this version because from spatial-image==1.2.0 the lower bound xarray>=2024.10.0 is added, and because xarray-dataclasses==1.8.0 supports xarray>=2024.10.0 but xarray-dataclasses==1.7.0 does not.

@LucaMarconato
Copy link
Collaborator Author

I now saw that @giovp used 1.9.1 as lower bound for conda-forge. We could therefore consider using 1.9.1 instead of 1.8.0 in this PR; or we could relax the conda-forege contraint. Giovanni WDYT?

@thewtex
Copy link
Contributor

thewtex commented Apr 23, 2025

I chose this version because from spatial-image==1.2.0 the lower bound xarray>=2024.10.0 is added, and because xarray-dataclasses==1.8.0 supports xarray>=2024.10.0 but xarray-dataclasses==1.7.0 does not.

The package manager should be able to resolve the dependency tree correctly on its own. However, there are issues in transitive package dependency specification as discussed in #28 and reported in astropenguin/xarray-dataclasses#240. Adding a further valid constraint to address some package manager's dependency resolution as workaround is ok, but it is does not resolve the underlying issue. In general, adding unnecessary constraints has the potential to cause issues with other packages in a package or project and should not be added unless needed.

I now saw that @giovp used 1.9.1 as lower bound for conda-forge. We could therefore consider using 1.9.1 instead of 1.8.0 in this PR; or we could relax the conda-forege contraint.

No, this additional constraint will cause more issues re: zarr 3 per astropenguin/xarray-dataclasses#240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants