-
Notifications
You must be signed in to change notification settings - Fork 7
Add documentation for example models #1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MaHaWo
commented
Jan 29, 2025
- adds a section in the docs that treats example models
- gives a short description for each model, which function it showcases and, where not too long and unwieldy, the mathematical formulation
- liver-simplified and circadian rythm models are based on papers and are complex mathematically, hence they are not spelled out in all detail. If they should be modified at some point (i.e., the models themselves), the description could be updated with that?
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 90.45% 90.47% +0.01%
==========================================
Files 130 130
Lines 13586 13632 +46
==========================================
+ Hits 12289 12333 +44
- Misses 1297 1299 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
…tial-model-editor/spatial-model-editor into add-documentation-for-example-models
for more information, see https://pre-commit.ci
…tial-model-editor/spatial-model-editor into add-documentation-for-example-models
should be done now, if you want to give it another look @lkeegan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - lgtm! a couple minor suggestions
fix typo Co-authored-by: Liam Keegan <[email protected]>
|