Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add documentation for example models #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Feb 4, 2025
Merged

Conversation

MaHaWo
Copy link
Contributor

@MaHaWo MaHaWo commented Jan 29, 2025

  • adds a section in the docs that treats example models
  • gives a short description for each model, which function it showcases and, where not too long and unwieldy, the mathematical formulation
  • liver-simplified and circadian rythm models are based on papers and are complex mathematically, hence they are not spelled out in all detail. If they should be modified at some point (i.e., the models themselves), the description could be updated with that?

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (e8cd219) to head (3d0a4ff).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
+ Coverage   90.45%   90.47%   +0.01%     
==========================================
  Files         130      130              
  Lines       13586    13632      +46     
==========================================
+ Hits        12289    12333      +44     
- Misses       1297     1299       +2     
Flag Coverage Δ
cli 20.14% <ø> (-0.07%) ⬇️
core 48.46% <ø> (-0.03%) ⬇️
gui 66.96% <ø> (+<0.01%) ⬆️
mainwindow 40.64% <ø> (+0.95%) ⬆️
sme 33.52% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaHaWo MaHaWo requested a review from lkeegan January 30, 2025 08:46
@MaHaWo
Copy link
Contributor Author

MaHaWo commented Jan 30, 2025

should be done now, if you want to give it another look @lkeegan

@MaHaWo MaHaWo linked an issue Jan 30, 2025 that may be closed by this pull request
Copy link
Member

@lkeegan lkeegan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - lgtm! a couple minor suggestions

Copy link

sonarqubecloud bot commented Feb 4, 2025

@MaHaWo MaHaWo merged commit f544b58 into main Feb 4, 2025
20 checks passed
@MaHaWo MaHaWo deleted the add-documentation-for-example-models branch February 4, 2025 13:07
@MaHaWo MaHaWo restored the add-documentation-for-example-models branch February 4, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation for the example models
2 participants