-
-
Notifications
You must be signed in to change notification settings - Fork 294
Render <changefreq> and <priority> #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spatie\Sitemap\Tags\Url provides setChangeFrequency() but it not renders in xml
Add changefreq
The tests are failing. Could you take a look? Probably you just need to update the snapshots. |
Add changefreq and priority
@freekmurze @Verkasha I updated my PR and top comment |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Idea of This PR:
The sitemap protocol allows the use of
<lastmod>
and<priority>
tags inside<url>
.For
<priority>
, any value from0.0
to1.0
is valid.This means we can safely render
<priority>0.0</priority>
.Therefore, the check for an
empty
value has been replaced with a check foris_null
.To ensure a consistent style for all optional values, their default is now set to
null
.If a value is not null during rendering, the corresponding tag will be rendered.
The
Spatie\Sitemap\Tags\Url
class has methods likesetPriority
andsetChangeFrequency
,which mean they were implemented previously, but later removed in this PR:
#545
However, since these fields are now optional (nullable), this implementation satisfies both groups:
those who want these tags and those who don’t.
Going forward, I recommend adhering to the official protocol:
https://www.sitemaps.org/protocol.html — instead of being Google-centric, as there are other search engines as well.
Additional small changes:
.phpunit.cache/test-results
from git.phpunit.cache
and.idea
(PhpStorm) to.gitignore
resources/views/url.blade.php