fix: spec-compliant overlay merge with version-aware dispatch#169
Merged
TristanSpeakEasy merged 1 commit intomainfrom Mar 1, 2026
Merged
fix: spec-compliant overlay merge with version-aware dispatch#169TristanSpeakEasy merged 1 commit intomainfrom
TristanSpeakEasy merged 1 commit intomainfrom
Conversation
Contributor
📊 Test Coverage ReportCurrent Coverage: Coverage Change: ✅ No change Coverage by Package
📋 Detailed Coverage by Function (click to expand)
Generated by GitHub Actions |
mfbx9da4
approved these changes
Feb 27, 2026
ThomasRooney
approved these changes
Feb 27, 2026
TristanSpeakEasy
added a commit
to speakeasy-api/speakeasy
that referenced
this pull request
Feb 27, 2026
Update openapi dependency to speakeasy-api/openapi#169 (unmerged) for testing spec-compliant overlay merge with version-aware dispatch.
4 tasks
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the overlay
updateaction merge behavior to be spec-compliant with version awareness. This is a fix-forward for PR #167, which incorrectly modifiedmergeNode— a function called both at the top level (action dispatch) and recursively (nested object merge). The spec defines different rules at each level.Key changes:
applyMergeas a top-level dispatch function implementing Action Object rules (§4.4.3): array target + non-array → append, array + array → concatenate, object → recursive merge, primitive → replacemergeNodebecomes recursive-only: type mismatches → error (1.1.0 strict) or replace (1.0.0 / 1.1.0 lax)mergeNodeIsV110OrLater()version detection (mirrors existingUsesRFC9535()pattern)strictmode through action handlers viamergeOptionsstructVersion behavior:
Test plan
mise ci)