Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

zair-sh
Copy link
Contributor

@zair-sh zair-sh commented Jul 25, 2024

fixes #-

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

I was experimenting with the recorder in my program. After some time, I checked the exported HTML in my browser, however, I noticed that every bold text is italic too. After digging into the source code, I found that the issue was caused by the code checking for Decoration.Bold instead of Decoration.Italic in two cases. This was causing the wrong text decorations in HtmlEncoder.BuildCss.

Here's the problematic code:
image

I didn't open an issue since this is just a single-line bug fix (and one test update).


Please upvote 👍 this pull request if you are interested in it.

@patriksvensson patriksvensson merged commit d79e6ad into spectreconsole:main Jul 25, 2024
@patriksvensson
Copy link
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants