Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

julien-blanchon
Copy link

What does this PR do?

Add SNAC

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@mravanelli mravanelli requested a review from poonehmousavi June 17, 2024 15:55
@mravanelli mravanelli added the enhancement New feature or request label Jun 17, 2024
@mravanelli
Copy link
Collaborator

thank you @julien-blanchon, it looks like tests are failing. Could you please take a look at it?

@julien-blanchon
Copy link
Author

Hey, just show your commit. Sorry I missed this message. Is it okay ?

@mravanelli
Copy link
Collaborator

I'm running some test. I will keep up updated @julien-blanchon!

@poonehmousavi
Copy link
Collaborator

thanks @julien-blanchon for this PR... since this model is using huggingface transformer, it should be moved to huggingface_transformer folder similar to Encodec.

@poonehmousavi
Copy link
Collaborator

@julien-blanchon Thanks for this PR. I have reviewed it, and everything works fine. I only made minor modifications, such as moving the model to the huggingface_transformer folder.

We recently released a benchmark for discrete audio and speech (DASB). You can find detailed information in this paper. The code is available in this repository. Since you have already added a new tokenizer to SpeechBrain, it would be a great contribution if you could also participate in the benchmark and evaluate this tokenizer across various tasks defined in DASB. I would be more than happy to help you through the process.

@julien-blanchon
Copy link
Author

Hey @poonehmousavi that a super good idea, I'm in. See you there

@julien-blanchon
Copy link
Author

Hummm, I'm quite unfamiliar with this codebase, I will need to read your paper before. I've open a Draft for us to discuss: speechbrain/benchmarks#40

@TParcollet
Copy link
Collaborator

TParcollet commented Jan 12, 2025

@poonehmousavi what should we do here? If you are happy with the code, please merge it. I don't like that, again, we add something untested. Please do verify that it is really impossible to test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants