Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix dataset preparation save folder in fluent-speech-commands recipe - #2860

Closed
tomaz-suller wants to merge 1 commit into
speechbrain:developfrom
tomaz-suller:patch-1
Closed

Fix dataset preparation save folder in fluent-speech-commands recipe#2860
tomaz-suller wants to merge 1 commit into
speechbrain:developfrom
tomaz-suller:patch-1

Conversation

@tomaz-suller

@tomaz-suller tomaz-suller commented Mar 14, 2025 •
edited
Loading

Copy link
Copy Markdown

What does this PR do?

Variable save_folder was mapped to hparams["output_folder"] which resulted in a file not found error. By we fix that by passing the correct parameter to prepare_FSC.

Did not bother opening issue since fix is trivial.

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@tomaz-suller
Fix dataset preparation save folder
d293958 
Variable `save_folder` was mapped to `hparams["output_folder"]` which resulted in a file not found error.
By we fix that by passing the correct parameter to `prepare_FSC`.
@tomaz-suller

tomaz-suller commented Mar 14, 2025

Copy link
Copy Markdown
Author

I'll run the recipe tests when I have some time to spare if really needed

@tomaz-suller

tomaz-suller commented Mar 14, 2025

Copy link
Copy Markdown
Author

I've realised there are other issues with this recipe, so for now I'll close this PR and open a new one fixing all of them instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tomaz-suller