Thanks to visit codestin.com
Credit goes to github.com

Skip to content

"Broken" image appear within an example html #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lesteve opened this issue Feb 5, 2016 · 2 comments
Closed

"Broken" image appear within an example html #94

lesteve opened this issue Feb 5, 2016 · 2 comments

Comments

@lesteve
Copy link
Member

lesteve commented Feb 5, 2016

Weird thing that happens when we tried to release nilearn.

One of the example failed and somehow the "Broken" image founds its way into the example html ...

sphinx-gallery

As you can notice the cell it does happen has no error. This is the next one which has an error.

It would be worth trying to reproduce this on a simpler example.
@lesteve lesteve changed the title Broken images appear within an example html "Broken" image appear within an example html Feb 5, 2016
@Titan-C
Copy link
Member

Titan-C commented Feb 5, 2016

This is the default behavior. Once the example fails the first images gets overwritten into the broken stamp. Because it is the first image that gets re-scaled into the thumbnail. But once the example fails we don't really care if the images continue to be on the right place, do we?

@lesteve
Copy link
Member Author

lesteve commented Feb 8, 2016

Once the example fails the first images gets overwritten into the broken stamp

Ah because the _001 image is the one being showed on the gallery, right? This is slightly surprising, but I agree this is not very high priority.

Titan-C added a commit to Titan-C/sphinx-gallery that referenced this issue Mar 6, 2016
@Titan-C
Check for failed example on last build
036fec0 
plots are current verifies not to find image mark file of broken example
to return True. If example has failed in previous builds, then plots are
not current and the example is build from start.

Fix sphinx-gallery#105
Fix sphinx-gallery#94 because first image is no longer overwritten
@Titan-C Titan-C mentioned this issue Mar 6, 2016
Merged
Titan-C added a commit to Titan-C/sphinx-gallery that referenced this issue Apr 12, 2016
@Titan-C
Check for failed example on last build
a24fd8a 
plots are current verifies not to find image mark file of broken example
to return True. If example has failed in previous builds, then plots are
not current and the example is build from start.

Fix sphinx-gallery#105
Fix sphinx-gallery#94 because first image is no longer overwritten
Titan-C added a commit to Titan-C/sphinx-gallery that referenced this issue Apr 21, 2016
@Titan-C
Check for failed example on last build
526b705 
plots are current verifies not to find image mark file of broken example
to return True. If example has failed in previous builds, then plots are
not current and the example is build from start.

Fix sphinx-gallery#105
Fix sphinx-gallery#94 because first image is no longer overwritten
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Titan-C @lesteve