Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH: make it possible to also specify abort_on_example_error in the sphinx_gallery_conf #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ENH: make it possible to also specify abort_on_example_error in the sphinx_gallery_conf #122

wants to merge 1 commit into from

Conversation

astrofrog
Copy link
Contributor

@astrofrog astrofrog commented Jun 3, 2016 •
edited
Loading

With these changes, it is possible to specify abort_on_example_error inside the normal sphinx_gallery_conf options.

@lesteve
Copy link
Member

lesteve commented Jun 6, 2016

I think this change is already in #97. @Titan-C can you double-check?

@lesteve
Copy link
Member

lesteve commented Jun 6, 2016 •
edited
Loading

Actually quickly looking at it, it doesn't seem to work as expected in #97. The value in app.builder.config.abort_on_example_error is always going to win over sphinx_gallery_conf. The differences between the values in sphinx_gallery_conf and the ones in app.builder.configare there for historic reasons and we should try to clean this up.

@lesteve lesteve mentioned this pull request Jun 28, 2016
Merged
@lesteve lesteve closed this in cbc69e4 Jul 25, 2016
@astrofrog astrofrog mentioned this pull request Jul 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astrofrog @lesteve