[MRG] Large codebase refactoring #160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc35faf to
b279f76
Compare
e23da53 to
7a007c8
Compare
|
Looks like this one needs a rebase. |
af4e4ee to
c88e24d
Compare
|
Merge after #190 |
This allows Sphinx-Gallery to be build by a direct call to sphinx-build, specifying the sources directory and the build output directory. There is no more the constrain to launch the build from the makefile is the sources directory. - Correct relative path when embedding links - Correct path during build - Summary of failing examples to work on relative path builds - Update tests - Update docs clean and build configs - Figure test for mayavi
New modules - execute blocks - save images - write rst review image test Load Agg in execute_blocks.py because tests load order is alphabetic Correct rendering of traceback in rst files Fix orphan repetition
|
My availability atm is very limited, @Titan-C, but I'll see if I can squeeze this in in a few weeks' time. |
|
Sorry to bother you @jnothman, the review request was an error on my side discovering the github interface for that. This PR I will not rebase anymore. I'll try to redo this changes in new smaller PR. |
|
No worries. Feel free to request reviews if you feel appropriate in any
case! :)
…On 2 April 2017 at 19:42, Óscar Nájera ***@***.***> wrote:
Closed #160 <#160>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#160 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEz68Qn0UA8jKCdMeL7ThC4x_4nwRheks5rr21sgaJpZM4KrxHr>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by the way PR #148 handles the creation of the jupyter notebook, and requires that PR to be merged first. The idea is writing the rst file shall be completely independent of the execution of the script. This PR splits the script execution from the preparation of the RST file