Enforce UTF8 encoding because that is not default on Windows #254
Conversation
|
I think #246 had the right approach of always trying to use utf-8. The only thing is that I never had the time to understand why the tests were failing ... |
|
If situation is dire enough, maybe this can be a "quick fix" until the other one has a chance to be investigated. This patch works for my use case and I have no motivation to investigate further. |
| else: | ||
| open_kwargs = {} | ||
|
|
||
| example_code_obj = identify_names(open(example_file, **open_kwargs).read()) |
There was a problem hiding this comment.
This is not going to work on Python 2.
There was a problem hiding this comment.
I'm running Python2 and it seems to work
There was a problem hiding this comment.
... oh wait, I thought this was on my PR, never mind!
There was a problem hiding this comment.
@lesteve , what do you mean? The tests passed.
They are related in the sense that we should be using |
|
Indeed. I wasn't specific enough either. This PR is targeting other place in the codebase which is not what PR #246 is covering. We still need to fix it here too. |
Fix #253
Also see astropy/sphinx-automodapi#29
UPDATE: Close #246