Fix status_iterator deprecation warning #255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesteve
reviewed
Jun 27, 2017
| iterator = app.status_iterator( | ||
| flat, os.path.basename(html_gallery_dir), colorfunc=fuchsia, | ||
| length=len(flat), stringify_func=lambda x: os.path.basename(x[1])) | ||
| if status_iterator is None: |
There was a problem hiding this comment.
Thanks for your PR. For slightly better readability, I would do something like:
try:
from sphinx.util import status_iterator
except ImportError:
# sphinx < 1.6
status_iterator = app.status_iterator
iterator = status_iterator(...)i.e. put the import in the _embed_code_links function.
|
I actually prefer the solution from PR #250 |
|
Ah, I was unaware of the fix being implemented already on #250. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix this warning with Sphinx 1.6:
c/c @bsipocz