Log what URLs fail to be resolved. #274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes debugging such failures much easier.
8742d60 to
85b1017
Compare
choldgraf
reviewed
Jul 30, 2017
| @@ -336,11 +336,13 @@ def _embed_code_links(app, gallery_conf, gallery_dir): | |||
| src_gallery_dir, | |||
| relative=True) | |||
| else: | |||
| doc_resolvers[this_module] = SphinxDocLinkResolver(url, | |||
| src_gallery_dir) | |||
There was a problem hiding this comment.
what was this before? Just a bunch of extra white space?
There was a problem hiding this comment.
Just a slightly awkward alignment which also made the line longer than 80 characters.
choldgraf
reviewed
Jul 30, 2017
| logger.warning("The following HTTP Error has occurred: %d", e.code) | ||
| logger.warning( | ||
| "HTTP error %d has occured while trying to resolve %s", | ||
| e.code, e.filename) |
There was a problem hiding this comment.
This seems reasonable to me...I say merge unless anybody objects
|
I have a similar change in the last commit of #272. |
QuLogic
reviewed
Jul 31, 2017
|
|
||
| except HTTPError as e: | ||
| logger.warning("The following HTTP Error has occurred: %d", e.code) | ||
| logger.warning( | ||
| "HTTP error %d has occured while trying to resolve %s", |
There was a problem hiding this comment.
You mis-corrected the spelling of 'occurred'.
|
Closed in favor of #272. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes debugging such failures much easier.