Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Expose examples sortkey #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Titan-C
Copy link
Member

@Titan-C Titan-C commented Jul 31, 2017

This is my proposal for #275
Here I directly expose a sortkey for ordering the examples within each subsection.
Default is for the moment case sensitive alphabetic ordering, which uses the None keyword. Functions for amount of code or file size are also provided.
Needs the documentation. Feel free to take over this PR.

@larsoner
Copy link
Contributor

Great, this gets us a lot of the way there.

Default is for the moment case sensitive alphabetic ordering, which uses the None keyword.

The default should remain the same, namely amount_of_code, no? Otherwise this is backward-incompatible.

@larsoner
Copy link
Contributor

(I'm happy to take this over in the next days/week unless someone else wants to.)

@Titan-C
Copy link
Member Author

Titan-C commented Jul 31, 2017

(I'm happy to take this over in the next days/week unless someone else wants to.)

go ahead. I'm leaving in 2 days and won't be able to contribute for the next week.

@Titan-C
Copy link
Member Author

Titan-C commented Jul 31, 2017

The default should remain the same, namely amount_of_code,

Yes, that shall be the default. The None was for testing here.

@choldgraf
Copy link
Contributor

@Eric89GXL ping me when you'd like me to take a look! I am happy to do so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants