MRG: Add thumbnail_size option #283
Conversation
b90d556 to
a6176fa
Compare
a6176fa to
937821a
Compare
|
I have now tested this and it works well to get PySurfer's images scaled nicely. It also makes the scaling slightly nicer for the BROKEN and default images by unifying the scaling routines instead of using different sizes. (This will have some presumably small negative impact on page load times.) CIs are happy. Ready for review/merge from my end. |
| @@ -198,3 +198,6 @@ pseudoxml: | |||
| $(SPHINXBUILD) -b pseudoxml $(ALLSPHINXOPTS) $(BUILDDIR)/pseudoxml | |||
| @echo | |||
| @echo "Build finished. The pseudo-XML files are in $(BUILDDIR)/pseudoxml." | |||
|
|
|||
| show: | |||
| @python -c "import webbrowser; webbrowser.open_new_tab('file://$(PWD)/$(BUILDDIR)/html/index.html')" | |||
There was a problem hiding this comment.
I'm +1 for this...my fingers will appreciate it in the long run
| @@ -85,6 +88,7 @@ want to build only one example so that you can link it in the documentation. In | |||
| you would do:: | |||
|
|
|||
| sphinx_gallery_conf = { | |||
| ... | |||
There was a problem hiding this comment.
good idea for these ellipses
| } | ||
|
|
||
| The gallery uses various CSS classes to display these thumbnails, which | ||
| default to maximum 160x160px. To change this, e.g. to display the images |
There was a problem hiding this comment.
why do you type the sizes in regular font here, but use code font above?
There was a problem hiding this comment.
Python vs CSS (approximately)
| # at all (maybe could be an option someday...) | ||
| img = img.resize((width_sc, height_sc), Image.BICUBIC) | ||
| # img.thumbnail((width_sc, height_sc), Image.BICUBIC) | ||
| # width_sc, height_sc = img.size # necessary if using thumbnail |
There was a problem hiding this comment.
what are these commented-out lines for? future dev?
There was a problem hiding this comment.
Using the thumbnail (non-upsampling) method if we ever want it (as suggested by the preceding comments)
|
Yes I tested these code suggestions on restoring the PySurfer examples back to 250x250px |
|
Before/after would be: https://sphinx-gallery.readthedocs.io/en/latest/auto_examples/index.html Though it's not terribly interesting because SG uses the defaults. |
|
ewww @Eric89GXL you're using matplotlib < 2.0?!?! That jet is killing me :-) LGTM |
Closes #282.
WIP because #279 needs to be merged first, then I can properly document how to get different thumbnail sizes.
In #277 @Titan-C you suggested this:
Here I've decided to avoid the step of combining keys. It seems like it could create a bit of deprecation pain for little gain in terms of readability.
I also added the "show"
Makefileoption because I've found it helpful previously, but I can split that off or remove it if need be.