-
Notifications
You must be signed in to change notification settings - Fork 211
MRG, ENH: Add private API for external scrapers #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@emmanuelle @banesullivan let me know if these docs look good to you: https://880-25860190-gh.circle-artifacts.com/0/rtd_html/configuration.html#image-scrapers Once you've implemented the private interface in the modules in the external list, it would be nice to say they can be used by just doing |
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
- Coverage 96.34% 96.31% -0.04%
==========================================
Files 29 29
Lines 2681 2711 +30
==========================================
+ Hits 2583 2611 +28
- Misses 98 100 +2
Continue to review full report at Codecov.
|
Looks good to me! I just added |
Cool. @choldgraf you okay with the updated docs and functionality? Here is what https://github.com/pyvista/pyvista/blob/master/pyvista/__init__.py#L34 |
Tested in pyvista/pyvista@d474c94 |
I meant with the nicer syntax |
Thanks @larsoner ! Looks good to me. |
Tested and working on a separate branch shown in my last linked commit ^^^ https://travis-ci.org/pyvista/pyvista/builds/534954544 |
Okay it's in, @banesullivan after you integrate and release, feel free to open a PR here to update the instructions to say |
@larsoner: PyVista 0.20.3 is out with the |
First make sure the string actually works in your builds. Then update the docs to say something like:
|
(update the SG gallery docs in the image scrapers section I mean) Also maybe we should now break up the section a bit. Let me try |
* Test for sphinx-gallery/sphinx-gallery#494 * Test string get for sphinx-gallery/sphinx-gallery#494 * Use latest sphinx-gallery * Require sphinx-gallery>=0.4.0
Closes #441.
Closes #493.