Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH: Use broader def of Animation #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2020
Merged

Conversation

larsoner
Copy link
Contributor

Matplotlib also has ArtistAnimation. It would be nice to have this for matplotlib (matplotlib/matplotlib#17477), maybe in a 0.7.1 release sometime? Let's wait to see what else breaks in the meantime before cutting one, though.

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #693 into master will decrease coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   97.81%   97.59%   -0.22%     
==========================================
  Files          32       32              
  Lines        3429     3495      +66     
==========================================
+ Hits         3354     3411      +57     
- Misses         75       84       +9     
Impacted Files Coverage Δ
sphinx_gallery/scrapers.py 97.23% <100.00%> (-0.49%) ⬇️
sphinx_gallery/utils.py 97.36% <0.00%> (-2.64%) ⬇️
sphinx_gallery/gen_gallery.py 95.53% <0.00%> (-1.41%) ⬇️
sphinx_gallery/sorting.py 100.00% <0.00%> (ø)
sphinx_gallery/tests/test_full.py 100.00% <0.00%> (ø)
sphinx_gallery/tests/test_sorting.py 100.00% <0.00%> (ø)
sphinx_gallery/tests/test_gen_gallery.py 100.00% <0.00%> (ø)
sphinx_gallery/tests/test_backreferences.py 100.00% <0.00%> (ø)
sphinx_gallery/tests/test_py_source_parser.py 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c60e7fc...e85ae9d. Read the comment docs.

@lucyleeow
Copy link
Contributor

@larsoner how did you know the error:

Exception occurred:
File "/home/circleci/.local/lib/python3.7/site-packages/sphinx/setup_command.py", line 196, in run
'caused by %s builder.' % app.builder.name)
distutils.errors.DistutilsExecError: caused by html builder.
The full traceback has been saved in /tmp/sphinx-err-q_gjzrqx.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at https://github.com/sphinx-doc/sphinx/issues. Thanks!

was caused by optipng? That error message is a bit cryptic.

@larsoner
Copy link
Contributor Author

Warnings are treated as errors, I ctrl-F'ed "warning" in the doc build log and found the warning

@lucyleeow
Copy link
Contributor

I see the -W is doing that in python setup.py build_sphinx -nW --keep-going but what does the exception above mean? Does it just mean that there was a warning somewhere?

@larsoner
Copy link
Contributor Author

Does it just mean that there was a warning somewhere?

Yeah. Newer sphinx is supposed to tell you that there was a warning that was treated as an error that killed the build but apparently it didn't work in this case

@lucyleeow
Copy link
Contributor

lucyleeow commented May 21, 2020 via email

@larsoner larsoner merged commit 113bbdc into sphinx-gallery:master May 21, 2020
@larsoner larsoner deleted the broader branch May 21, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants