Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ENH: Add run_stale_examples config var #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 23, 2020
Merged

ENH: Add run_stale_examples config var #759

merged 10 commits into from
Oct 23, 2020

Conversation

larsoner
Copy link
Contributor

Makes it much easier to have a Makefile target to force re-running of a specific example/examples. See extended explanation in configuration.rst.

@larsoner
Copy link
Contributor Author

Needed to move nightly to allowed failures until NumPy has 3.10 pre wheels. Added a 3.8 build (overdue) but no 3.9 until NumPy, matplotlib, etc. have time to get wheels out.

@codecov
Copy link

codecov bot commented Oct 16, 2020 •
edited
Loading

Codecov Report

Merging #759 into master will increase coverage by 0.02%.
The diff coverage is 96.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   97.52%   97.55%   +0.02%     
==========================================
  Files          32       32              
  Lines        3758     3840      +82     
==========================================
+ Hits         3665     3746      +81     
- Misses         93       94       +1
Impacted Files Coverage Δ
sphinx_gallery/gen_gallery.py 94.51% <81.81%> (-0.41%) ⬇️
sphinx_gallery/gen_rst.py 97.94% <100.00%> (+0.22%) ⬆️
sphinx_gallery/tests/test_full.py 99.60% <100.00%> (+0.02%) ⬆️
sphinx_gallery/tests/test_utils.py 100.00% <0.00%> (ø)
sphinx_gallery/tests/test_notebook.py 100.00% <0.00%> (ø)
sphinx_gallery/tests/test_load_style.py 100.00% <0.00%> (ø)
sphinx_gallery/tests/test_gen_gallery.py 100.00% <0.00%> (ø)
sphinx_gallery/tests/test_backreferences.py 100.00% <0.00%> (ø)
sphinx_gallery/tests/test_py_source_parser.py 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefaea3...933eb11. Read the comment docs.

@larsoner
Copy link
Contributor Author

I think codecov is okay (96.66%). @lucyleeow feel free to review/merge

@larsoner larsoner mentioned this pull request Oct 20, 2020
Closed
lucyleeow
lucyleeow reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@lucyleeow lucyleeow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and questions - sorry test_rebuild was confusing for me.

Also could we add to the description of test_rebuild:

# Make sure that examples that haven't been changed aren't run twice.
# Also checks `run_stale_examples` config works.

(also sorry for delay, I have been busy).

@larsoner
Copy link
Contributor Author

Thanks for the nice wording changes, pushed @lucyleeow

@lucyleeow
Copy link
Contributor

Thanks for the changes. I am still confused by test_rebuild. The status I get for both 'run_stale' and 'modify' rebuilds (when I test locally) are both:

building [mo]: targets for 0 po files that are out of date
building [html]: targets for 27 source files that are out of date

Is it for some CI that the 'run_stale' and 'modify' give different values? Also why do I have 'po' after the number?

Finally, are we getting so many 'changed' files because we added binder to the tinybuild config (#745 (comment)) ? (I vaguely remember this but forgot details)

lucyleeow
lucyleeow reviewed Oct 22, 2020
View reviewed changes
sphinx_gallery/tests/test_full.py Outdated
Comment on lines 579 to 580
# (sometimes this is 8, other times 9, depending on Windows/Linux for some
# unknown reason)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me 'run_stale' gives '8 changed' and 'modify' gives '9 changed' - which seems to make sense as we modify a file in 'modify'...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I had to put [8|9] was from 5164de3 -- Travis (Linux) passed with 9 but AppVeyor (Windows) wanted 8.

@larsoner
Copy link
Contributor Author

Is it for some CI that the 'run_stale' and 'modify' give different values?

If you change the order IIRC (as I had it originally, modify was before run_stale) yes you get different values. I'll get rid of the conditional now, though, since the order has to be modify last (which means both runs get the all-files-out-of-date version).

Also why do I have 'po' after the number?

I have no idea what this means.

I think the bottom line is that we just need to get these to pass

@lucyleeow lucyleeow merged commit c9214b5 into sphinx-gallery:master Oct 23, 2020
@lucyleeow
Copy link
Contributor

Thanks @larsoner !

@larsoner larsoner deleted the run-stale branch October 23, 2020 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucyleeow lucyleeow lucyleeow left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsoner @lucyleeow