-
Notifications
You must be signed in to change notification settings - Fork 207
BUG URL quote branch names and filepaths in Binder URLs #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The changes look good. I think the error is related to myavi build @larsoner ?
|
To fix CIs for now I would pin |
…nx-gallery into sdhiscocks-binder_url_quote
sphinx_gallery/gen_rst.py
Outdated
def execute_code_block(compiler, block, example_globals, | ||
script_vars, gallery_conf): | ||
"""Execute the code block of the example file.""" | ||
def _ast_module(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucyleeow something is wrong with the diff, this stuff shouldn't be in here
Not sure what happened there but fixed now I think. Thanks @larsoner |
Thanks @sdhiscocks ! |
Fixes issue with special characters in Binder URLs for branch names and file paths. No characters that need quoting are allowed for GitHub orgs and repos