Thanks to visit codestin.com
Credit goes to github.com

Skip to content

BUG URL quote branch names and filepaths in Binder URLs #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 11, 2021

Conversation

sdhiscocks
Copy link
Contributor

Fixes issue with special characters in Binder URLs for branch names and file paths. No characters that need quoting are allowed for GitHub orgs and repos

@lucyleeow
Copy link
Contributor

The changes look good. I think the error is related to myavi build @larsoner ?

Building wheels for collected packages: mayavi, Sphinx, pyface, traitsui, memory-profiler, pypandoc, apptools, configobj, envisage
  Building wheel for mayavi (setup.py): started
  Building wheel for mayavi (setup.py): finished with status 'error'
  ERROR: Command errored out with exit status 1:
   command: /usr/share/miniconda/bin/python -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-goy0uugo/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-goy0uugo/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d /tmp/pip-wheel-a85htd_0
       cwd: /tmp/pip-req-build-goy0uugo/
  Complete output (33 lines):
  running bdist_wheel
  running build
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-req-build-goy0uugo/setup.py", line 411, in <module>
      setup(
    File "/usr/share/miniconda/lib/python3.8/site-packages/numpy/distutils/core.py", line 169, in setup
      return old_setup(**new_attr)
    File "/usr/share/miniconda/lib/python3.8/site-packages/setuptools/__init__.py", line 153, in setup
      return distutils.core.setup(**attrs)
  ModuleNotFoundError: No module named 'vtk'
  ----------------------------------------
  ERROR: Failed building wheel for mayavi
  Running setup.py clean for mayavi

@lucyleeow lucyleeow added the bug label Jul 3, 2021
@larsoner
Copy link
Contributor

larsoner commented Jul 6, 2021

To fix CIs for now I would pin vtk<=9.0.1 in some requirements. 9.0.2/9.0.3 cause problems and Mayavi needs to be updated to at least build (though it's still broken on Windows even with this PR):

enthought/mayavi#1050

def execute_code_block(compiler, block, example_globals,
script_vars, gallery_conf):
"""Execute the code block of the example file."""
def _ast_module():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucyleeow something is wrong with the diff, this stuff shouldn't be in here

@lucyleeow
Copy link
Contributor

Not sure what happened there but fixed now I think. Thanks @larsoner

@lucyleeow lucyleeow merged commit b176e22 into sphinx-gallery:master Jul 11, 2021
@lucyleeow
Copy link
Contributor

Thanks @sdhiscocks !

@sdhiscocks sdhiscocks deleted the binder_url_quote branch July 11, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants